Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove specific filter for classnames #81

Open
swissspidy opened this issue Oct 1, 2018 · 1 comment
Open

Remove specific filter for classnames #81

swissspidy opened this issue Oct 1, 2018 · 1 comment
Labels

Comments

@swissspidy
Copy link
Contributor

There isn't a project where we've actually needed the rest_likes.classnames filter.

Having this filter means we need to pass the list of class names to the JS as well, which makes things a bit more complex.

I don't think there's a need for that. We could just hardcode the classnames in the markup / JS to reduce complexity.

@swissspidy
Copy link
Contributor Author

Oh, and of course this would make integration with Gutenberg or for example AMP easier because we can actually rely on the class names being the same instead of worrying about someone filtering them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant