Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability Detector E2E test unexpectedly passes when it fails to parse vulnerabilities #5107

Closed
juliamagan opened this issue Mar 14, 2024 · 1 comment

Comments

@juliamagan
Copy link
Member

Description

Related to #5106, during the tests executed for 4.8.0 Beta 4, in wazuh/wazuh#22493, it has been observed that the tests are marked as passed even if there were errors when parsing the vulnerabilities. This behavior has been found specifically in tests_syscollector_first_second_scan_consistency_index.

We should adjust the code so that if there are any errors during the test, the test fails for that host and only continues on the hosts that have not failed. It should also be marked as failed.

Report: Test_e2e_system_244_test_vulnerability_detector.zip

@juliamagan
Copy link
Member Author

juliamagan commented Mar 25, 2024

It has been decided that this is an uncommon error to appear from an internal tool for testing, that it makes sense that if it fails, it will affect the rest of the tests, so it is not necessary to include the logic that allows moving forward with the rest of the hosts if it fails here. Solved in #5146 from #5106.

@juliamagan juliamagan closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2024
@juliamagan juliamagan removed their assignment Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant