Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy protocol header #3

Merged
merged 73 commits into from
Oct 14, 2023
Merged

Proxy protocol header #3

merged 73 commits into from
Oct 14, 2023

Conversation

megsdevs
Copy link
Contributor

@megsdevs megsdevs commented Oct 12, 2023

VAL-1250

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #3 (e7dbdec) into master (13ae39f) will increase coverage by 8.59%.
The diff coverage is 83.58%.

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   68.13%   76.73%   +8.59%     
==========================================
  Files          11       13       +2     
  Lines        1133     1732     +599     
==========================================
+ Hits          772     1329     +557     
- Misses        361      403      +42     
Files Coverage Δ
src/tls_openssl/mod.rs 82.96% <100.00%> (+6.59%) ⬆️
src/tls_rustls/mod.rs 77.03% <100.00%> (+6.64%) ⬆️
src/proxy_protocol/future.rs 87.75% <87.75%> (ø)
src/server.rs 77.31% <80.64%> (+5.39%) ⬆️
src/proxy_protocol/mod.rs 83.23% <83.23%> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@0xAlcibiades 0xAlcibiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one change and will check back on the v1 support.

.gitignore Outdated Show resolved Hide resolved
@0xAlcibiades
Copy link
Member

programatik29/axum-server#89 - original PR/feedback for ref.

src/proxy_protocol/future.rs Outdated Show resolved Hide resolved
src/proxy_protocol/mod.rs Outdated Show resolved Hide resolved
src/proxy_protocol/mod.rs Outdated Show resolved Hide resolved
src/proxy_protocol/mod.rs Outdated Show resolved Hide resolved
src/proxy_protocol/mod.rs Outdated Show resolved Hide resolved
src/proxy_protocol/mod.rs Outdated Show resolved Hide resolved
src/proxy_protocol/mod.rs Outdated Show resolved Hide resolved
src/proxy_protocol/mod.rs Outdated Show resolved Hide resolved
src/server.rs Outdated Show resolved Hide resolved
@0xAlcibiades
Copy link
Member

0xAlcibiades commented Oct 13, 2023 via email

@0xAlcibiades 0xAlcibiades merged commit 6d93b42 into master Oct 14, 2023
18 checks passed
@0xAlcibiades 0xAlcibiades deleted the proxy-protocol-header branch October 14, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants