-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy protocol header #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
==========================================
+ Coverage 68.13% 76.73% +8.59%
==========================================
Files 11 13 +2
Lines 1133 1732 +599
==========================================
+ Hits 772 1329 +557
- Misses 361 403 +42
|
0xAlcibiades
requested changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one change and will check back on the v1 support.
programatik29/axum-server#89 - original PR/feedback for ref. |
0xAlcibiades
requested changes
Oct 13, 2023
dbelv
suggested changes
Oct 13, 2023
Yes, I was more looking for a comment here on the why of why they are exported in code. Should have made that more clear.
… On Oct 12, 2023, at 23:05, Dave Belvedere ***@***.***> wrote:
@dbelv commented on this pull request.
---------------------------------------------------------------
In [src/tls_rustls/mod.rs](#3 (comment)):
> @@ -303,7 +303,7 @@ async fn config_from_pem_file(
}
#[cfg(test)]
-mod tests {
+pub(crate) mod tests {
It allows other test modules to import the public functions
—
Reply to this email directly, [view it on GitHub](#3 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AVOT3C3XSBQ3LOTTW5ZOUQLX7CVYNANCNFSM6AAAAAA55Y5FDA).
You are receiving this because your review was requested.Message ID: ***@***.***>
|
Co-authored-by: Dave Belvedere <90095005+dbelv@users.noreply.github.com>
Co-authored-by: Dave Belvedere <90095005+dbelv@users.noreply.github.com>
0xAlcibiades
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VAL-1250