Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit Tests for Preprocess Function in preprocess.go #140

Closed
coderabbitai bot opened this issue Apr 3, 2024 · 1 comment · Fixed by #325
Closed

Add Unit Tests for Preprocess Function in preprocess.go #140

coderabbitai bot opened this issue Apr 3, 2024 · 1 comment · Fixed by #325
Assignees
Milestone

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 3, 2024

This issue tracks the task of ensuring the correctness of the preprocessing logic by adding unit tests for the function and its helper functions, as discussed in the pull request review.

Context:

The unit tests should cover various scenarios to validate the functionality of the function and its helper functions within .

@Pitasi
Copy link
Contributor

Pitasi commented Apr 3, 2024

In general, the status of unit tests for the shield package it's not great, I took some shortcuts to push this thing out.

The code looks fairly well-separated to me, so adding new unit tests (maybe fuzzing as well) should be easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants