-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event Mode missing Page 1 Area 1-3 #32
Comments
mmm, yeah I'll patch that up. Event maps are hard coded in atm without detection: https://github.com/waicool20/KAGA/blob/master/src/main/kotlin/com/waicool20/kaga/views/tabs/sortie/SortieTabView.kt#L80 For a quick fix you can add 1-3 by yourself and recompile before I'm able to patch it |
Created a pull request for it here: #33 |
I'm writing a patch that will have better scanning, hard coding the events in isn't very future proof and won't work reliably in future events eg. Page 1 contains 2 maps only but 1-3 will show anyways. So I'll have to decline the pull request. |
Yeah, should scan for current event assets' filename and dynamically generate the list. |
In a sense it currently is, but it just cuts off the aforementioned list in whatever last map it finds in kancolle-auto. I'll get to writing a better implementation when i get back home...but for now you can use that quick fix |
One option is to just use a regex to match 1-1,1-2, 1-3, 2-1,2-2, etc from the event_panel and then insert Page break placeholder above the first item that starts with 1, 2, 3 etc. |
Patched: e8b600a |
Fixing #32, better dynamic scanning of event maps
Hi,
I am using the Spring 2017 event branch of kancolle-auto, but KAGA only shows Area 1-1 and 1-2 in drop down for page 1.
Not sure if this is a bug with KAGA or kancolle-auto, because it looks like you're automatically detecting event assets?
The text was updated successfully, but these errors were encountered: