feat(build): pass git commit sha for ReSpec based specs

[dontcallmedom]

Useful if https://github.com/w3c/respec/pull/4561 gets merged

[sidvishnoi]

I think best would be add the gitRevision to each config override above, instead of setting it later.
Does Bikeshed set it automatically in build process, or we can pass it via config also? If not passable, can pass conditionally for ReSpec only.

[dontcallmedom]

bikeshed does it automatically already on its own

[dontcallmedom]

can you say a bit more why you think it should be in the override? this feels typically like a setting that shouldn't need to be overridden by a static configuration file

[sidvishnoi]

I was suggesting that only because as we can to pass it down less manually that way, as configOverride will get passed to ReSpec as respecConfig override (via URL parameters).
https://github.com/w3c/spec-prod/pull/167/files#diff-f065c431b4f45758b2e047fcd38135fdcb2327564def7a33ab41e84898210fc8L95-L101

We use same method for setting publishDate:

spec-prod/src/prepare-build.ts

Lines 139 to 140 in 958b6d5

	if (toolchain === "respec") {
	conf.publishDate = publishDate = conf.publishDate || publishDate;

[sidvishnoi]

(I'll refactor this part someday, I find it confusing too)

[dontcallmedom]

would you be willing to make the code work like you think it should? I'm struggling a bit…

[sidvishnoi]

I think if you can add following above and reset src/build.ts, that'd be enough:

const configOverride = {
	gh: getConfigOverride(inputs.GH_PAGES_BUILD_OVERRIDE),
	w3c: getConfigOverride(inputs.W3C_BUILD_OVERRIDE),
};
+ if (toolchain === 'respec) {
+ 	configOverride.gh.gitRevistion = configOverride.w3c.gitRevision = gitRevision;
+ }

[sidvishnoi]

If not, feel free to do it what you find simpler. We can refactor it eventually.

[sidvishnoi]

Thanks @dontcallmedom!
I hope to be properly back at maintaining these projects soon!