-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
registerForeignFetch({ origins, scope }) optional #982
Comments
I'm in favour of removing this part of the API. As you say, it's explicit in the event handler, and adding an additional level of scoping seems confusing. @mkruisselbrink - am I missing something about this API? |
Well, we wanted to keep the model that CORS has around to some extent. CORS requires an origin. |
You already have to provide the origin in the response. It kinda feels redundant in |
Although currently origin is not required there (there being |
If you don't provide an origin, the returned response is always opaque. |
Closing due to removing foreign fetch. |
The foreign fetch scopes and origins should be optional. This wouldnt be a security concern because the SW is already explicitly intending to handle foreign fetches.
The text was updated successfully, but these errors were encountered: