Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html no longer defines "referrer source" #834

Closed
mkruisselbrink opened this issue Feb 12, 2016 · 8 comments
Closed

html no longer defines "referrer source" #834

mkruisselbrink opened this issue Feb 12, 2016 · 8 comments
Labels
Milestone

Comments

@mkruisselbrink
Copy link
Collaborator

@annevk removed the definition of "referrer source" in whatwg/html@7c5555a , but this spec still links to that (in Run Service Worker and the importScripts definition). This should somehow be fixed.

@domenic
Copy link
Contributor

domenic commented Feb 12, 2016

It looks to me like this is solvable by removing the reference to "referrer source" in the definition of the settings object (in Run Service Worker), then in importScripts saying "with referrer set to settings object's API base URL."

@annevk
Copy link
Member

annevk commented Feb 13, 2016

If referrer matches the client you passes to Fetch, you don't have to set it at all. Referrer is never the base URL by the way (unless it happens to match the URL of the resource).

@jakearchibald
Copy link
Contributor

Pre F2F notes: Does @domenic's proposal work here?

@domenic
Copy link
Contributor

domenic commented Jul 27, 2016

Hmm, now that I know more about this, probably not. Setting the referrer from a settings object is in general tricky; see https://w3c.github.io/webappsec-referrer-policy/#determine-requests-referrer.

@jungkees
Copy link
Collaborator

F2F: Change SW to use referrer policy language.

@jungkees
Copy link
Collaborator

@annevk, @domenic, here's my plan (Correct me if I'm wrong):

Remove the reference to "referrer source" in the definition of the settings object (in Run Service Worker) and add a reference to "referrer policy" instead that returns "worker global scope's referrer policy". Worker global scope's referrer policy is set when fetching the script in Update algorithm as other workers do in run a worker: "Set worker global scope's referrer policy to the result of parsing the Referrer-Policy header of response."

@annevk
Copy link
Member

annevk commented Sep 20, 2016

Sounds reasonable.

@domenic
Copy link
Contributor

domenic commented Sep 20, 2016

Sounds exactly right, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants