Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VAppBar): fix inability to scroll to the bottom #19921

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

lzl0304
Copy link
Contributor

@lzl0304 lzl0304 commented May 30, 2024

Description

fixes #19090

After altering scrollHeight, determining scroll direction becomes invalid.

Markup:

<template>
  <v-layout ref="app" class="rounded rounded-md">
    <v-app-bar color="grey-lighten-2" name="app-bar" scroll-behavior="hide" />
    <v-navigation-drawer
      color="grey-darken-2"
      name="drawer"
      expand-on-hover
      permanent
      rail
    />

    <v-main
      class="d-flex flex-column align-center justify-center"
      style="min-height: 300px"
    >
      <div v-for="n in 17" :key="n" class="pa-16 ma-2 w-50 bg-green text-center">
        box {{ n }}
      </div>
    </v-main>

    <v-footer class="justify-center" color="grey" name="footer" app>
      FOOTER
    </v-footer>
  </v-layout>
</template>

@lzl0304 lzl0304 marked this pull request as draft May 30, 2024 08:15
@lzl0304 lzl0304 marked this pull request as ready for review May 30, 2024 09:20
@johnleider
Copy link
Member

Could you reach out to me on Discord? https://community.vuetifyjs.com

@johnleider johnleider added this to the v3.6.x milestone Jun 11, 2024
@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VAppBar VAppBar labels Jun 11, 2024
@johnleider johnleider merged commit 7ccff92 into vuetifyjs:master Jun 11, 2024
10 checks passed
@lzl0304 lzl0304 deleted the fix-19090 branch June 26, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VAppBar VAppBar T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.5.1] Bounce on scroll to bottom of the page with VAppBar set with scroll-behavior="hide"
2 participants