Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VDataTable): select all checkbox showing when not enabled on mobile #19727

Conversation

webdevnerdstuff
Copy link
Contributor

@webdevnerdstuff webdevnerdstuff commented Apr 30, 2024

Description

Fixes the issue where the select all checkbox is showing up next to the sortby select on mobile when data-table-select is not present in the columns

Markup:

const appendIcon = computed(() => {
  const showSelectColumn = columns.value.find(column => column.key === 'data-table-select')

  if (showSelectColumn == null) {
    return
  }

  return allSelected.value ? '$checkboxOn' : someSelected.value ? '$checkboxIndeterminate' : '$checkboxOff'
})

@webdevnerdstuff webdevnerdstuff changed the title fix select all checkbox showing when not enabled on mobile fix(VDataTable): select all checkbox showing when not enabled on mobile Apr 30, 2024
@webdevnerdstuff webdevnerdstuff marked this pull request as ready for review May 1, 2024 00:48
@johnleider johnleider added this to the v3.6.x milestone May 1, 2024
@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VDataTable VDatatable labels May 1, 2024
@johnleider johnleider merged commit 0825e2d into vuetifyjs:master May 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VDataTable VDatatable T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants