This repository has been archived by the owner on May 28, 2023. It is now read-only.
Implemented basic image processing/caching factories #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this we get a local action witch is the current behavior. Then we have file caching which is disabled by default. This creates and md5 of the URL and for that he saves the processed image to file.
|
One thing that is missing is a google cloud storage implementation for caching which I now going to work on. |
ResuBaka
added a commit
to gastrohero/vue-storefront-api
that referenced
this pull request
Jul 26, 2019
|
Hi, @ResuBaka Does it work for other media images as well apart from product and category? I mean for static blocks or CMS pages? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this we get a local action witch is the current behavior.
Then we have file caching which is disabled by default. This creates
and md5 of the URL and for that he saves the processed image to file.
With this you can change the logic of caching (s3, redis, ...) and you can change the implementation of processor which and what you can to with the image.
This is a basic implementation and I would think needs better naming.