Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

fix: default sorter doesn't work fine in Safari #54

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Conversation

billyyyyy3320
Copy link
Member

Summary

Because only the dates in frontmatter written in 2-digits will be transformed, other dates written in single-digit, such as 2020-1-1 will be treated as string. Some browsers (e.g. Safari) don't support this format.

Relevant issue: vuejs/vuepress#2097

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant