Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static type="checkbox" with v-bind (fix #7811) #7819

Merged
merged 3 commits into from
Mar 13, 2018

Conversation

privatenumber
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@@ -34,7 +34,7 @@ function preTransformNode (el: ASTElement, options: CompilerOptions) {
if (map[':type'] || map['v-bind:type']) {
typeBinding = getBindingAttr(el, 'type')
}
if (!typeBinding && map['v-bind']) {
if (!map.type && !typeBinding && map['v-bind']) {
Copy link
Member

@jkzing jkzing Mar 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would make following case lose type binding:

<input type="checkbox" v-model="test" v-bind="{type: typeBindingValue}">

So maybe

typeBinding = `(${map['v-bind']}).type || '${map.type}'`

EDIT: the one above is not comprehensive, while map.type still could be undefined.

typeBinding = `(${map['v-bind']}).type || ${JSON.stringify(map.type)}`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hirokiosame If you could add the test as well, that would be great 👌

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should allow v-bind to override a static type, it's gonna be confusing if done accidentally and I don't think there's a valid use case.

@yyx990803 yyx990803 merged this pull request into vuejs:dev Mar 13, 2018
This was referenced Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants