Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass errors encountered within nextTick to Vue.config.errorHandler #6730

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

rubys
Copy link
Contributor

@rubys rubys commented Oct 2, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

I've found it easier to debug my application if I use:

Vue.config.errorHandler = function(err, vm, info) {throw err};

Unfortunately, I found that my error handler wasn't being called if the error was encountered as a result of updating a reactive element. Tracing back, I found that this was due to nextTick calling console.error directly instead of handleError. I made this change locally and found that it fixed my problem, and didn't cause any failures with 'npm test'.

@yyx990803 yyx990803 merged commit ae347a5 into vuejs:dev Oct 3, 2017
ztlevi pushed a commit to ztlevi/vue that referenced this pull request Feb 14, 2018
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants