Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #6284: avoid iterating non-observable arrays #6467

Merged
merged 1 commit into from
Sep 13, 2017

Conversation

fenduru
Copy link
Contributor

@fenduru fenduru commented Aug 28, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: Performance

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

While this introduces a slight behavior change, I believe the only scenario in which this would cause breakage is if an application has a non-reactive object inside of a non-reactive array and is relying on the reactivity system to detect changes to the elements in that array. This seems incredibly unlikely to happen as that use case has already gone to lengths to opt out of reactivity in the first place, so I expect this to be nothing but a performance improvement for those use cases if they exist.

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
I am unable to build or run tests. The development setup instructions are insufficient to get a dev environment working due to #4338.

@fenduru fenduru changed the title fix #6284: fix #6284: avoid iterating non-observable arrays Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants