Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-core): generate different keys for multiple v-if #1589

Merged
merged 2 commits into from
Jul 15, 2020
Merged

fix(compiler-core): generate different keys for multiple v-if #1589

merged 2 commits into from
Jul 15, 2020

Conversation

HcySunYang
Copy link
Member

fix: #1587.

@HcySunYang
Copy link
Member Author

For elements(nodes) with v-if/v-if-else/v-else at the same level(siblings), generate incremental keys for them so that they are always different.

@yyx990803 yyx990803 merged commit 64c7b2f into vuejs:master Jul 15, 2020
WB9292 added a commit to WB9292/vue-next that referenced this pull request Oct 23, 2020
@WB9292
Revert "fix(compiler-core): generate incremental keys for v-if/else-i…
83e9a64 
…f/else chains (vuejs#1589)"

This reverts commit 64c7b2f.
@rightaway
Copy link

@HcySunYang @yyx990803 is this PR why https://vuejs.org/v2/style-guide/#v-if-v-else-if-v-else-without-key-use-with-caution was removed from style guide for Vue 3? It not necessary anymore to use key on v-if or v-else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

children not update
3 participants
@HcySunYang @rightaway @yyx990803