Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useId): ensure useId consistency when using serverPrefetch #12128

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

yangxiuxiu1115
Copy link
Contributor

fix #12102

Copy link

github-actions bot commented Oct 8, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (+12 B) 38.1 kB (+11 B) 34.3 kB (+10 B)
vue.global.prod.js 160 kB (+12 B) 58 kB (+10 B) 51.5 kB (-21 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.1 kB (+11 B) 19 kB (+12 B) 17.3 kB (+11 B)
createApp 55.7 kB (+12 B) 21.5 kB (+13 B) 19.6 kB (+23 B)
createSSRApp 59.7 kB (+12 B) 23.2 kB (+16 B) 21.1 kB (+41 B)
defineCustomElement 60.5 kB (+12 B) 23 kB (+16 B) 20.9 kB (+12 B)
overall 69.4 kB (+12 B) 26.5 kB (+13 B) 24.2 kB (+30 B)

Copy link

pkg-pr-new bot commented Oct 8, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12128

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12128

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12128

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12128

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12128

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12128

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12128

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12128

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12128

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12128

vue

pnpm add https://pkg.pr.new/vue@12128

commit: 79ef696

@edison1105 edison1105 added scope: ssr 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. labels Oct 8, 2024
@@ -870,12 +869,16 @@ function setupStatefulComponent(
setupContext,
],
)
const isAsyncSetup = isPromise(setupResult)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaked the lines here so all the const declarations are together for better minification

@yyx990803 yyx990803 merged commit b4d3534 into vuejs:main Oct 11, 2024
13 checks passed
@yangxiuxiu1115 yangxiuxiu1115 deleted the fix/useId branch October 11, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: ssr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onServerPrefetch causing unstable ids from useId, leading to hydration mismatches
3 participants