Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Suspense): mount runs too early when used in Transition #9388

Merged
merged 2 commits into from
Oct 21, 2023
Merged

fix(Suspense): mount runs too early when used in Transition #9388

merged 2 commits into from
Oct 21, 2023

Conversation

pikax
Copy link
Member

@pikax pikax commented Oct 12, 2023 •
edited
Loading

closes #5844 , #5952

Suspense was executing effects before the Transition ended.

@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 85.9 kB (+14 B) 32.7 kB (+19 B) 29.5 kB (+19 B)
vue.global.prod.js 132 kB (+14 B) 49.4 kB (+12 B) 44.3 kB (-12 B)

Usages

Name Size Gzip Brotli
createApp 47.9 kB 18.8 kB 17.2 kB
createSSRApp 50.6 kB 19.9 kB 18.2 kB
defineCustomElement 50.3 kB 19.6 kB 17.9 kB
overall 61.2 kB (+14 B) 23.7 kB (+13 B) 21.5 kB (-35 B)

@pikax pikax force-pushed the pikax/suspense_with_transition branch from 9bbab23 to d45e07a Compare October 12, 2023 20:32
@pikax pikax marked this pull request as ready for review October 12, 2023 20:35
@pikax pikax requested a review from yyx990803 October 12, 2023 20:38
@pikax pikax mentioned this pull request Oct 12, 2023
Closed
@edison1105
Copy link
Member

LGTM

@pikax
Copy link
Member Author

pikax commented Oct 13, 2023

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Oct 13, 2023

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools ✅ success ✅ success
nuxt ✅ success ✅ success
pinia ❌ failure ❌ failure
quasar ❌ failure ❌ failure
router ✅ success ✅ success
test-utils ✅ success ✅ success
vant ✅ success ✅ success
vite-plugin-vue ✅ success ✅ success
vitepress ✅ success ✅ success
vue-i18n ✅ success ✅ success
vue-macros ❌ failure ❌ failure
vuetify ✅ success ✅ success
vueuse ❌ failure ✅ success
vue-simple-compiler ✅ success ✅ success

@pikax pikax added scope: transition scope: suspense ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Oct 13, 2023
@pikax pikax mentioned this pull request Oct 20, 2023
Closed
@yyx990803 yyx990803 merged commit 00de3e6 into main Oct 21, 2023
15 checks passed
@yyx990803 yyx990803 deleted the pikax/suspense_with_transition branch October 21, 2023 13:24
@benjaminrobinet
Copy link

🥰

@ejfox
Copy link

ejfox commented Oct 21, 2023

Thank you!!

@awacode21 awacode21 mentioned this pull request Nov 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. scope: suspense scope: transition
Projects
Issue / PR Management
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<Suspense> + <Transition> means mounted() runs too early
7 participants
@pikax @edison1105 @vue-bot @benjaminrobinet @ejfox @antfu @yyx990803