fix(runtime-core): do not fire lifecycle hooks during unmounting

[edison1105]

close #9264 #8898 #9617
the root cause is mounted hook is already queued in pendingPostFlushCbs and isUnmounted is false.
we can't change instance.isUnmounted = true to synchronous perform because it could be a breaking change

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	89.6 kB (+84 B)	34.1 kB (+56 B)	30.7 kB (+28 B)
vue.global.prod.js	147 kB (+84 B)	53.3 kB (+23 B)	47.7 kB (+63 B)

Usages

Name	Size	Gzip	Brotli
createApp	49.9 kB (+84 B)	19.5 kB (+36 B)	17.9 kB (+65 B)
createSSRApp	53.2 kB (+84 B)	20.8 kB (+32 B)	19 kB (+23 B)
defineCustomElement	52.2 kB (+84 B)	20.3 kB (+41 B)	18.5 kB (+44 B)
overall	63.4 kB (+84 B)	24.5 kB (+40 B)	22.2 kB (+16 B)

[Disservin]

Thanks for the pr, I cant test it right now but I assume that also fixes the issue of my reproduction right in #9264 and not only posva's ?

[edison1105]

@Disservin Yes, The root cause is the same.

[Disservin]

Nice, thanks!

[Disservin]

#9617 is probably also related

[Disservin]

Any update on this? ^^ There have been 3 issues related to this #9264, #8898 and #9617 and another issue which was opened in pinia.

[netlify]

❌ Deploy Preview for vue-sfc-playground failed.

Name	Link
🔨 Latest commit	c011f34
🔍 Latest deploy log	https://app.netlify.com/sites/vue-sfc-playground/deploys/659d18f65c263b0008f90231

[netlify]

❌ Deploy Preview for vue-next-template-explorer failed.

Name	Link
🔨 Latest commit	c011f34
🔍 Latest deploy log	https://app.netlify.com/sites/vue-next-template-explorer/deploys/659d18f6deae4f0008a8d445

[yyx990803]

/ecosystem-ci run

[vue-bot]

📝 Ran ecosystem CI: Open

suite	result	latest scheduled
language-tools	✅ success	✅ success
nuxt	✅ success	✅ success
pinia	✅ success	✅ success
primevue	✅ success	✅ success
quasar	✅ success	✅ success
radix-vue	✅ success	✅ success
router	✅ success	✅ success
test-utils	✅ success	✅ success
vant	❌ failure	✅ success
vite-plugin-vue	✅ success	✅ success
vitepress	✅ success	✅ success
vue-i18n	✅ success	✅ success
vue-macros	✅ success	✅ success
vuetify	✅ success	✅ success
vueuse	✅ success	✅ success
vue-simple-compiler	✅ success	✅ success

[edison1105]

vant's test case failed, it seems related to this commit and they should update those snapshots.

[skirtles-code]

Does this also need to account for KeepAlive?

I've put together a couple of Playground examples that might be relevant here:

• Playground 1
• Playground 2

For the first example, the key thing to notice is what happens if you click the button multiple times. Contrast that with what happens if you comment out the show.value = false line.

For the second example, the mounted hook is being cancelled but not the activated hook.

I don't know whether these would be considered out of scope for this change, but I thought they were at least worth considering.

[yyx990803]

The fix is correct, but I refactored the implementation to make it more efficient in 27d9948

• Before: iterating hooks, then for each hook there is searching + splicing
• After: only iterating hooks once