fix(runtime-core): before cloneIfMounted, should first check if the object is a VNode (#8778) #8784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bject is a VNode (vuejs#8778) close vuejs#8778
| // already vnode, this should be the most common since compiled templates | ||
| // always produce all-vnode children arrays | ||
| return cloneIfMounted(child) | ||
| } else { | ||
| // strings and numbers | ||
| // strings and numbers or object that doesn't a vnode |
There was a problem hiding this comment.
I think a warning or error would be more appropriate, rather than converting the object to a string.
edison1105
added
🍰 p2-nice-to-have
|
Maybe superseded by #12038? |
|
I'm really sorry, I didn't notice this PR before create https://github.com/vuejs/core/pull/12038.😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #8778
In my opinion, it seems sufficient to directly check
isVNode. However, shouldVNodeChildinclude theobjecttype? For example, when usingrender!.call, it seems that we have no control over what it returns.