Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): props destructing default value type checking with unresolved type (#8326) #8340

Merged
merged 1 commit into from
May 17, 2023

Conversation

kalvenschraut
Copy link
Contributor

@kalvenschraut kalvenschraut commented May 16, 2023

The inferred type at this point is ['null'] and I don't think it can ever be the UNKNOWN_TYPE due to the code here

If it can be the UNKNOWN_TYPE via some other path, then I think would need to check for both. Null should be an allow any type so it shouldn't even bother trying to validate it default value here also,

closes #8326

@yyx990803 yyx990803 merged commit f69dbab into vuejs:main May 17, 2023
@yyx990803
Copy link
Member

Thanks for fixing your own issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue 3.3 causing unresolved types to fail build when using props destructuring with a default value
2 participants