Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reactivity): fix the tracking when readonly + reactive is used for Map #3604

Merged
merged 2 commits into from
May 7, 2021
Merged

fix(reactivity): fix the tracking when readonly + reactive is used for Map #3604

merged 2 commits into from
May 7, 2021

Conversation

HcySunYang
Copy link
Member

Fix: #3602

@HcySunYang HcySunYang added ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. need test The PR has missing test cases. labels Apr 14, 2021
@HcySunYang
Copy link
Member Author

This solution is flawed, but I am going to bed. Wait for me to wake up and fix it 😅

@HcySunYang HcySunYang changed the title fix(reactivity): fix the tracking when reactive + readonly is used for collections fix(reactivity): fix the tracking when reactive + readonly is used for Map Apr 15, 2021
@HcySunYang HcySunYang changed the title fix(reactivity): fix the tracking when reactive + readonly is used for Map fix(reactivity): fix the tracking when readonly + reactive is used for Map Apr 15, 2021
@HcySunYang HcySunYang removed the need test The PR has missing test cases. label Apr 15, 2021
@yyx990803 yyx990803 merged commit 5036c51 into vuejs:master May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusBorg LinusBorg LinusBorg approved these changes

Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. scope: reactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

readonly() breaks reactivity of Map
3 participants
@HcySunYang @LinusBorg @yyx990803