Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler-core): parse modifiers as expression to provide location data #11819

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

KazariEX
Copy link
Contributor

@KazariEX KazariEX commented Sep 5, 2024

We need to provide completion support for custom directives.

vuejs/language-tools#4810

Copy link

github-actions bot commented Sep 5, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.7 kB 33.9 kB
vue.global.prod.js 159 kB (+98 B) 57.6 kB (+22 B) 51.2 kB (+31 B)

Usages

Name Size Gzip Brotli
createApp 55.2 kB 21.2 kB 19.4 kB
createSSRApp 59.1 kB 22.9 kB 20.9 kB
defineCustomElement 59.9 kB 22.8 kB 20.7 kB
overall 68.9 kB 26.3 kB 23.9 kB

Copy link

pkg-pr-new bot commented Sep 5, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11819

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11819

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11819

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11819

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11819

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11819

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11819

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11819

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11819

vue

pnpm add https://pkg.pr.new/vue@11819

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11819

commit: d40e385

packages/compiler-core/src/transforms/vBind.ts Outdated Show resolved Hide resolved
packages/compiler-core/src/transforms/vBind.ts Outdated Show resolved Hide resolved
Co-authored-by: edison <daiwei521@126.com>
@edison1105
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Sep 5, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success failure
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros failure success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105
Copy link
Member

edison1105 commented Sep 5, 2024

The vue-marcos's tests failed because of this commit

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: compiler labels Sep 5, 2024
@yyx990803
Copy link
Member

Merging and releasing in a patch as this is not an end-user-facing feature.

@yyx990803 yyx990803 merged commit 3f13203 into vuejs:main Sep 5, 2024
13 checks passed
@KazariEX KazariEX deleted the feat/modifiers-exp branch September 5, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged. scope: compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants