Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(jsx): HTMLDialogElement add close event #11811

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

Level8Broccoli
Copy link
Contributor

Add missing "close" event on the HTMLDialogElement.

https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement/close_event

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: types labels Sep 5, 2024
@yyx990803 yyx990803 merged commit 3634f7a into vuejs:main Sep 5, 2024
10 of 12 checks passed
Copy link

github-actions bot commented Sep 5, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.7 kB 34 kB
vue.global.prod.js 159 kB 57.6 kB 51.3 kB

Usages

Name Size Gzip Brotli
createApp 55.3 kB 21.3 kB 19.4 kB
createSSRApp 59.3 kB 22.9 kB 20.9 kB
defineCustomElement 60 kB 22.8 kB 20.8 kB
overall 69.1 kB 26.4 kB 24 kB

Copy link

pkg-pr-new bot commented Sep 5, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11811

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11811

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11811

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11811

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11811

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11811

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11811

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11811

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11811

vue

pnpm add https://pkg.pr.new/vue@11811

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11811

commit: 4a20aff

@Level8Broccoli Level8Broccoli deleted the patch-1 branch September 5, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged. scope: types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants