Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(defineModel): detect changes respect custom getter #11527

Closed
wants to merge 8 commits into from
Closed

fix(defineModel): detect changes respect custom getter #11527

wants to merge 8 commits into from

Conversation

liuseen-l
Copy link
Contributor

@liuseen-l liuseen-l commented Aug 6, 2024 •
edited
Loading

resolve: #11526

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.2 kB (+15 B) 34.6 kB (+2 B) 31.1 kB (-6 B)
vue.global.prod.js 147 kB (+15 B) 54.1 kB (+2 B) 48.1 kB (-10 B)

Usages

Name Size Gzip Brotli
createApp 49.7 kB 19.5 kB 17.8 kB
createSSRApp 53.2 kB 21 kB 19.1 kB
defineCustomElement 51.9 kB 20.2 kB 18.5 kB
overall 63.2 kB 24.5 kB 22.3 kB

@netlify Netlify
Copy link

netlify bot commented Aug 6, 2024

❌ Deploy Preview for vue-next-template-explorer failed.

Name Link
🔨 Latest commit 5e3e2dd
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/66b21cfac7b15d0008129986

@liuseen-l liuseen-l changed the title fix: useModel comparison logic fix(runtime-core): useModel comparison logic Aug 6, 2024
@edison1105
Copy link
Member

Could you please add a test case?

@edison1105 edison1105 added need test The PR has missing test cases. 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: defineModel labels Aug 7, 2024
@edison1105 edison1105 added ready for review This PR requires more reviews and removed need test The PR has missing test cases. labels Aug 7, 2024
@edison1105 edison1105 changed the title fix(runtime-core): useModel comparison logic fix(runtime-core): useModel supports custom getter Aug 7, 2024
@edison1105 edison1105 changed the title fix(runtime-core): useModel supports custom getter fix(useModel): detect changes respect custom getter Aug 7, 2024
@edison1105 edison1105 changed the title fix(useModel): detect changes respect custom getter fix(defineModel): detect changes respect custom getter Aug 7, 2024
@liuseen-l liuseen-l mentioned this pull request Aug 7, 2024
Merged
@yyx990803 yyx990803 closed this in e042888 Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edison1105 edison1105 edison1105 approved these changes

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready for review This PR requires more reviews scope: defineModel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Watching a model with custom get and setter doesn't work in some cases.
2 participants
@liuseen-l @edison1105