Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shallowReadonly): add shallowReadonly and set computed to be shallowReadonly #447

Merged
merged 5 commits into from
Jul 22, 2020
Merged

feat(shallowReadonly): add shallowReadonly and set computed to be shallowReadonly #447

merged 5 commits into from
Jul 22, 2020

Conversation

pikax
Copy link
Member

@pikax pikax commented Jul 20, 2020 •
edited
Loading

Adding shallowReadonly and setting the computed to behave as shallowReadonly.

This will allow to check if we are allowed to set the value on the computed.
fix #445

This behaviour has not been approved nor in vue-next.

vuejs/core#1654 vue next PR

@pikax pikax mentioned this pull request Jul 20, 2020
Closed
@pikax pikax marked this pull request as ready for review July 21, 2020 04:24
@pikax pikax requested a review from antfu July 21, 2020 04:24
antfu
antfu approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@antfu antfu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you help updating the missing api list in the readme as well? Thanks

@antfu
Copy link
Member

antfu commented Jul 21, 2020

Done. I will publish a new version after Vue RC3 :)

@pikax pikax merged commit cfbbcec into vuejs:master Jul 22, 2020
@pikax pikax deleted the feat/treat_computed_with_no_setter_as_shallowReadonly branch July 22, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

help/Feature request: iscomputed
2 participants
@pikax @antfu