Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential bug: 64min should read 64mb #73

Closed
v6 opened this issue Dec 3, 2015 · 3 comments
Closed

Potential bug: 64min should read 64mb #73

v6 opened this issue Dec 3, 2015 · 3 comments

Comments

@v6
Copy link

v6 commented Dec 3, 2015

The following section of a correct configuration file requires 64mb as a default, not 64min:

# Automatic rewrite of the append only file.
# Redis is able to automatically rewrite the log file implicitly calling
# BGREWRITEAOF when the AOF log size grows by the specified percentage.
#
# This is how it works: Redis remembers the size of the AOF file after the
# latest rewrite (if no rewrite has happened since the restart, the size of
# the AOF at startup is used).
#
# This base size is compared to the current size. If the current size is
# bigger than the specified percentage, the rewrite is triggered. Also
# you need to specify a minimal size for the AOF file to be rewritten, this
# is useful to avoid rewriting the AOF file even if the percentage increase
# is reached but it is still pretty small.
#
# Specify a percentage of zero in order to disable the automatic AOF
# rewrite feature.

auto-aof-rewrite-percentage 100
auto-aof-rewrite-min-size 64mb

I found this problem in two areas:

https://github.com/arioch/puppet-redis/search?utf8=%E2%9C%93&q=64min

@v6
Copy link
Author

v6 commented Dec 3, 2015

// , Can I make a pull request for this one?

@v6
Copy link
Author

v6 commented Dec 3, 2015

// , Also, is this, in fact, a bug?

@arioch
Copy link
Contributor

arioch commented Dec 10, 2015

That's a bug and is fixed in 2771a9d.
Thanks for reporting.

@arioch arioch closed this as completed Dec 10, 2015
@petems petems changed the title // , Potential bug: 64min should read 64mb Potential bug: 64min should read 64mb Dec 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants