Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Oracle as one of Redhat operating systems for params file #988

Closed
patchsmyle opened this issue Dec 21, 2016 · 1 comment · Fixed by #1077
Closed

Add Oracle as one of Redhat operating systems for params file #988

patchsmyle opened this issue Dec 21, 2016 · 1 comment · Fixed by #1077
Assignees

Comments

@patchsmyle
Copy link

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 3.7
  • Ruby:
  • Distribution:
  • Module version: 0.5

What are you seeing

Oracle is caught by the RedHat Family, but not by the module_os_overrides key.

What behaviour did you expect instead

To toggle the 'manage_repo' key to True

Current code:

'RedHat': {
  if ($::operatingsystem in ['RedHat', 'CentOS'] and $::operatingsystemmajrelease in ['5', '6', '7']) {
    $_module_os_overrides = {
      'manage_repo' => true,
    }

Suggested edit:

'RedHat': {
  if ($::operatingsystem in ['RedHat', 'CentOS','Oracle'] and $::operatingsystemmajrelease in ['5', '6', '7']) {
    $_module_os_overrides = {
      'manage_repo' => true,
    }
@wyardley
Copy link
Collaborator

wyardley commented Apr 13, 2017

@patchsmyle is the versioning the same as vanilla RedHat (and will it work with the same repos)? Have you tested the above? If so, this is indeed a fairly easy fix.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants