Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gzip is enabled by default #1085

Closed
mbelscher opened this issue May 8, 2017 · 1 comment
Closed

gzip is enabled by default #1085

mbelscher opened this issue May 8, 2017 · 1 comment
Labels
beginner-friendly enhancement New feature or request

Comments

@mbelscher
Copy link

mbelscher commented May 8, 2017

The module has gzip is enabled by default, when someone configures to uses HTTPS without modifying this parameter they are susceptible to www.breachattack.com.

It would be more appropriate and safer for the default to be undef and take the default of the nginx module which is "off" when not configured.

If someone wants to explicitly configure then it should be added.
This will avoid misconfiguration and opening users sites to the possible attack.

@wyardley
Copy link
Collaborator

wyardley commented Aug 4, 2017

I agree that, especially for SSL, it should default to off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner-friendly enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants