[dev.icinga.com #12724] RSpec tests without effect

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12724

Created by bsheqa on 2016-09-14 09:26:06 +00:00

Assignee: bsheqa
Status: Closed (closed on 2016-09-15 14:19:10 +00:00)
Target Version: v0.3.0
Last Update: 2016-09-15 19:19:06 +00:00 (in Redmine)

---

We use the following test for multiple classes:

    context "#{os} with host => foo (not a valid IP address)" do
      let(:params) { {:host => 'foo'} }

      it do
        expect {
          is_expected.to contain_icinga2__feature('graphite')
        }.to raise_error(Puppet::Error, /"foo" is not a valid IP address/)
      end
    end

where this line has no effect at all:

 is_expected.to contain_icinga2__feature('graphite')

My suggestion is to remove the 'contain_icinga2__feature' check where only params are tested

    context "#{os} with host => foo (not a valid IP address)" do
      let(:params) { {:host => 'foo'} }

      it { is_expected.to raise_error(Puppet::Error, /"foo" is not a valid IP address/) }
      end
    end

[icinga-migration]

Updated by lbetz on 2016-09-15 08:40:27 +00:00

Works correctly, but it seems to be the old syntax.

[icinga-migration]

Updated by bsheqa on 2016-09-15 13:41:16 +00:00

• Status changed from Feedback to Assigned
• Assigned to set to bsheqa

[icinga-migration]

Updated by bsheqa on 2016-09-15 14:19:10 +00:00

• Status changed from Assigned to Closed
• Done % changed from 0 to 100

[icinga-migration]

Updated by lbetz on 2016-09-15 19:19:06 +00:00

• Done % changed from 100 to 90

Forgot spec/define/feature_spec.rb.

And check all othe specs again.