Add support for custom certificates to old PuppetDB #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #68 |
bastelfreak
commented
Jun 9, 2022
bastelfreak
force-pushed
the
foo
branch
5 times, most recently
from
8ec808a
to
39830a9
Compare
|
requires some documentation, but the cods seems to be fine and working \o/ |
bastelfreak
force-pushed
the
foo
branch
8 times, most recently
from
6dbcf53
to
5cffc61
Compare
|
I think it's ready for review now :) |
evgeni
reviewed
Jun 14, 2022
This implementation is based on a suggestion from Josh Cooper: ``` Yeah can use https://www.rubydoc.info/gems/puppet/Puppet/X509/CertProvider to load x509 certificates and then create a custom ssl context using https://www.rubydoc.info/gems/puppet/Puppet/SSL/SSLProvider, and pass it into any of the http client methods, e.g. x509 = Puppet::X509::CertProvider.new cacerts = x509.load_cacerts_from_pem(File.read('...', encoding: Encoding::UTF_8)) prov = Puppet::SSL::Provider.new ctx = prov.create_context(cacerts: cacerts, revocation: false, ...) response = Puppet.runtime[:http].get(URI('https://...', options: { ssl_context: ctx }) ``` Slack link: https://puppetcommunity.slack.com/archives/C0W1X7ZAL/p1652464163822119?thread_ts=1652453262.819079&cid=C0W1X7ZAL
evgeni
reviewed
Jun 14, 2022
evgeni
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is based on a suggestion from Josh Cooper:
Slack link:
https://puppetcommunity.slack.com/archives/C0W1X7ZAL/p1652464163822119?thread_ts=1652453262.819079&cid=C0W1X7ZAL
depends on #68