-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Mermaid support #405
add Mermaid support #405
Conversation
adding support for Mermaid (https://mermaid.js.org/) Co-authored-by: Kyle Rames <kyle@rames.org>
I looked at the code climate error and I think given what the method is doing it is easier to read this way rather than breaking it up into individual methods. I will defer to your judgement though @ahmedash95. |
e290dcb
to
1370ad9
Compare
1370ad9
to
e9bfc85
Compare
e5f4911
to
2f3950b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!! 🎩'd on a local project and it's working well.
I would heartily endorse this. Worked great for me and avoids installing the what, two dozen dependencies that Added to my :development group
and then ran it as asked. |
As an aside, I had been trying to do this with Its also worthwhile that this works without having to connect to the db in the first place, so maybe they are complementary? In any case 👍 would merge again 😄 |
attr_accessor :graph | ||
|
||
setup do | ||
self.graph = ["classDiagram"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking you needed an erDiagram
for databases but I have not RTFMd
:bump what can I do to help get this merged -- ❤️ using it. |
Hey @johnpaulashenfelter, glad to see how useful it is. let's ping the maintainers to check this and hopefully get it merged |
PING @kerrizor, can you check this PR, please? |
Thanks, as always, for your patience with my being slow on updates and responses here! This is a great contribution, and I'm happy to merge. I've wanted to add mermaid support for quite some time, and this is a great first step; I especially appreciated making it an option, while maintaining graphviz as the default for now. I suspect that the direction to go for a next major release will be to flip this and make 🧜♀️ the default generator, but this gives us the ability to exercise this implementation and uncover any deeper problems before proceeding. Well done. |
Regarding #226. This PR adds support for generating diagrams using Mermaid.
here is an example for Event Forms sample schema.
Mermaid generator can be configured by passing
generator=mermaid
to the erd command or specifying the generator in configuration file to be mermaid. and it generates.mmd
file.