Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP feat: progressively load the widgets while the kernel is executing #768

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Nov 19, 2020

  1. WIP feat: progressively load the widgets while the kernel is executing

    This will connect to the kernel as soon as possible, and tries to create
    widget during execution. This avoids having to get all the widgets after
    execution, and is an alterative to;
    voila-dashboards#766
    
    Issues:
     * since the whole jupyter message handling is 'synchronous' it awaits
       at a top level and goes all the way down, get_model needs to be resolved
       without any new message coming from the kernel.
     * Despite making handle_comm_open not returning a promise, we still get
       a stalling of the whole message q.
    
    Despite these issues, the loading time is significantly reduced, since
    the page renders almost instantly when it succeeds (e.g. when no widgets
    are missed).
    maartenbreddels committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    13fe75d View commit details
    Browse the repository at this point in the history