Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only handle .ipynb files #190

Closed
jtpio opened this issue Jun 5, 2019 · 0 comments · Fixed by #191
Closed

Only handle .ipynb files #190

jtpio opened this issue Jun 5, 2019 · 0 comments · Fixed by #191

Comments

@jtpio
Copy link
Member

jtpio commented Jun 5, 2019

For now the VoilaHandler can only process notebook files (.ipynb).

However the handler is currently using path_regex from jupyter_server.base.handlers, which catches all files:

https://github.com/QuantStack/voila/blob/cadc6e801a0a4537ee216fdfe0b67682e054d9ba/voila/app.py#L37

As a result, some non .ipynb files can hit the VoilaHandler:

WARNING:tornado.general:404 GET /voila/render/b06871f281fee6b241d60582ae9369b9.ttf (127.0.0.1): No such file or directory: b06871f281fee6b241d60582ae9369b9.ttf

It would make sense to use a custom path_regex to only catch .ipynb files (at least for now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant