-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support configuration of default compatibility matrix if matrix is not configured before configuring drivers #118
Conversation
Codecov Report
@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 51.47% 51.80% +0.33%
==========================================
Files 6 6
Lines 1457 1467 +10
==========================================
+ Hits 750 760 +10
Misses 610 610
Partials 97 97
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
This PR will bring in the following changes :
Which issue(s) this PR fixes:
Fixes #112
Test Report Added?:
Test Report:
1. When compat-matrix is configured explicitly
i. vdoctl configure compatibility matrix
ii. vdoctl deploy
iii. vdoctl configure drivers
2. When compat-matrix is not configured explicitly
i. vdoctl deploy
ii.vdoctl configure drivers
Special notes for your reviewer: