-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataDownload fails during restore when SnapshotMoveData: true
for empty PVC workload
#7388
Comments
SnapshotMoveData: true
SnapshotMoveData: true
for empty PVC workload
Good catch, let me try to refactor the code. |
With PR #7442 and #7396 merged, this use case is covered by nightly kubeadm vanilla cluster with zfs-localpv internal test pipeline. |
@danfengliu is there a case for empty volume? |
Yes, in PR #7396 , there is a CSI datamover backup volume info test case for datamover test, and in PR #7442, I modified this test case to prepare more than 1 PVC and leave some of PVs empty, so if this case is running in kubeadm vanilla cluster with zfs-localpv pipeline (in this pipeline, a new PV is an actual empty PV with no files created automatically by system), your issue will be coved. As you can see, this pipeline only has 1 failed test case which is [BackupVolumeInfo][CSIDataMover]: |
I see. So tests added, just not yet resolved. Thanks! |
Hi, When will this fix be available in a version please ? I see that it is merged on |
The coming v1.14.0 ships with this fix. |
Thanks a lot for the quick response ! |
What steps did you take and what happened:
Create workload mounting empty CSI volume
Create Backup With SnapshotMoveData: true
Create Restore
What did you expect to happen:
Application to become available
What happened
kubectl get restore test-restore479 -o jsonpath='{.status.phase}' PartiallyFailed
The following information will help us better understand what's going on:
Velero 1.12
If you are using earlier versions:
Please provide the output of the following commands (Pasting long output into a GitHub gist or other pastebin is fine.)
kubectl logs deployment/velero -n velero
velero backup describe <backupname>
orkubectl get backup/<backupname> -n velero -o yaml
velero backup logs <backupname>
velero restore describe <restorename>
orkubectl get restore/<restorename> -n velero -o yaml
velero restore logs <restorename>
Anything else you would like to add:
This is crosspost for https://issues.redhat.com/browse/OADP-3106
Environment:
velero version
): 1.12velero client config get features
):kubectl version
):/etc/os-release
):Vote on this issue!
This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.
The text was updated successfully, but these errors were encountered: