Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Restic to v0.14.0 for faster data pruning #5650

Closed
sgalsaleh opened this issue Nov 30, 2022 · 4 comments
Closed

Upgrade Restic to v0.14.0 for faster data pruning #5650

sgalsaleh opened this issue Nov 30, 2022 · 4 comments
Assignees

Comments

@sgalsaleh
Copy link
Contributor

sgalsaleh commented Nov 30, 2022

Describe the problem/challenge you have

We're noticing that Restic takes a very long time when pruning large amounts of data which makes it challenging to prune the data frequently.

It looks like Restic v0.14.0 includes an improvement that handles pruning large repository data much faster. Reference: restic/restic#3611

Restic v0.14.0 was released in August, and it would be great if Velero could update Restic to that version so that users can have pruning happen more frequently without sacrificing stability.

Describe the solution you'd like

Upgrade Restic to v0.14.0

Anything else you would like to add:
No

Environment:

  • Velero version (use velero version): v1.9.3
  • Kubernetes version (use kubectl version): N/A
  • Kubernetes installer & version: N/A
  • Cloud provider or hardware configuration: N/A
  • OS (e.g. from /etc/os-release): N/A

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@sseago
Copy link
Collaborator

sseago commented Nov 30, 2022

It looks like the just-released 1.9.4 has already bumped restic up to 0.14.0, but we haven't made the same bump for the 1.10 branch or on main yet.

@sgalsaleh
Copy link
Contributor Author

sgalsaleh commented Nov 30, 2022

Oh, interesting. Thanks for pointing that out! I only checked the Restic version in the Makefile in the main branch and assumed that's the current version. It seems unexpected that Velero 1.10 would use an older version of Restic than Velero 1.9.4 though, so hopefully that can be updated as well?

@sseago
Copy link
Collaborator

sseago commented Nov 30, 2022

I expect that 1.10.1 will update Restic, although I don't know exactly when that will come out. 1.9.4 was actually released slightly later than 1.10.

@qiuming-best
Copy link
Contributor

I've bumped up restic v0.14.0 to 1.10 branch, So I close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants