This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
add Request interface to make plugin testing easier #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wayne Witzel III wayne@riotousliving.com
What this PR does / why we need it:
Adds a Request interface for plugins to allow easy mocking/faking of the service.Request type. This allows plugins to properly unit test their route handlers when they are accessing things like the Context.
A sample plugin was created to test this new interface: https://github.com/wwitzel3/octant-actions-plugin
Which issue(s) this PR fixes
Special notes for your reviewer: This is a breaking API change⚠️
cc: @GarySmith