Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] URL validation is not considering subdomains #16

Open
vitorfhc opened this issue Jun 11, 2019 · 0 comments · May be fixed by #20
Open

[Improvement] URL validation is not considering subdomains #16

vitorfhc opened this issue Jun 11, 2019 · 0 comments · May be fixed by #20
Labels
Hacktoberfest improvement Issue related to possible improvements

Comments

@vitorfhc
Copy link
Owner

validate_url method in cfaster/scrappers/utils/urls.py is not considering the possibility of having subdomains.
@vitorfhc vitorfhc added the improvement Issue related to possible improvements label Jun 11, 2019
@byarmis byarmis linked a pull request Oct 11, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest improvement Issue related to possible improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added tests and sub-domain validation byarmis/cfaster
1 participant
@vitorfhc