Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-app): handle invalid template #3615

Merged
merged 1 commit into from
Jun 1, 2021
Merged

fix(create-app): handle invalid template #3615

merged 1 commit into from
Jun 1, 2021

Conversation

jamesgeorge007
Copy link
Contributor

Description

Follow up of #3044

Before

before

After

Screenshot 2021-06-01 at 11 15 31 AM

Additional context

N/A

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu merged commit 4578a8c into vitejs:main Jun 1, 2021
@jamesgeorge007 jamesgeorge007 deleted the hotfix/create-app branch June 1, 2021 05:59
ygj6 pushed a commit to ygj6/vite that referenced this pull request Jun 1, 2021
@jamesgeorge007 @ygj6
fix(create-app): handle invalid template (vitejs#3615)
07f9316
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesgeorge007 @antfu