Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-vite): move ESLint "ignores" config to a separate object in React templates #17885

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

simonlary
Copy link
Contributor

Description

fixes #17883

Simply put ignores in its own object to apply it to all configs by default, so the dist directory is correctly ignored.

Copy link

stackblitz bot commented Aug 15, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bluwy bluwy changed the title fix: move ESLint "ignores" config to a separate object in React templates (fixes #17883) fix(create-vite): move ESLint "ignores" config to a separate object in React templates Aug 15, 2024
@bluwy bluwy merged commit 1b3b702 into vitejs:main Aug 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React Typescript template's ESLint configuration doesn't correctly ignore dist directory
2 participants