You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To facilitate the caller life it could be cool to use %w verb instead of %v in fmt.Errorf call.
This way the caller can, for example, easily check for ENOBUFS error:
iferrors.Is(err, syscall.ENOBUFS) {
but this needs go1.13.
As this repo requires 1.12, this means we have to change this requirement to 1.13 (to avoid doing horrible things with build tags, as go1.12 is now more than 3 years old and no longer maintained by the go team.)
Is this change a no-go or do you accept a PR?
Note that v1.1.0 does not encapsulate routeSubscribeAt error with fmt.Errorf, so errors.Is(err, syscall.ENOBUFS) works fine.
The text was updated successfully, but these errors were encountered:
routeSubscribeAt
returns 3 kinds of errors. 2 of them are encapsulated withfmt.Errorf
.To facilitate the caller life it could be cool to use
%w
verb instead of%v
infmt.Errorf
call.This way the caller can, for example, easily check for
ENOBUFS
error:but this needs go1.13.
As this repo requires 1.12, this means we have to change this requirement to 1.13 (to avoid doing horrible things with build tags, as go1.12 is now more than 3 years old and no longer maintained by the go team.)
Is this change a no-go or do you accept a PR?
Note that v1.1.0 does not encapsulate
routeSubscribeAt
error withfmt.Errorf
, soerrors.Is(err, syscall.ENOBUFS)
works fine.The text was updated successfully, but these errors were encountered: