Import style and event types from specific base libraries #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
force-pushed
the
x/type-fix
branch
from
ce7dc2f
to
a8553f8
Compare
chrisgervang
approved these changes
Aug 12, 2023
| @@ -220,8 +219,8 @@ export type Transform = { | |||
| pointLocation: (p: Point) => LngLat; | |||
|
|
|||
| // Mapbox only | |||
| getProjection?: () => Projection; | |||
| setProjection?: (projection: Projection) => void; | |||
| getProjection?: () => any; | |||
There was a problem hiding this comment.
any or import from mapbox spec file?
There was a problem hiding this comment.
Currently this is mapbox-gl only but maplibre may implement it differently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To account for the divergence between Mapbox and Maplibre styles, this PR stops using
@maplibre/maplibre-gl-style-specfor both endpoints. Style and event types are passed in as generics specific to each base map library.