Extending ArrayObject and overwriting offsetSet leads to unsolvable ParamNameMismatch error

[marcreichel]

PHP: 8.2.13
Psalm: 5.16.0/5.17.0

We have a class which extends ArrayObject and overwrites the offsetSet method.
The method has the two arguments $key and $value as defined in ArrayObject. ArrayObject itself implements ArrayAccess where the method signature is different already.

We now have three errors (since Psalm 5.16.0):

• Argument 1 of Our\Class::offsetSet has wrong name $key, expecting $offset as defined by ArrayAccess::offsetSet (see https://psalm.dev/230)
• Argument 1 of Our\Class::offsetSet has wrong name $key, expecting $index as defined by ArrayObject::offsetSet (see https://psalm.dev/230)
• Argument 2 of Our\Class::offsetSet has wrong name $value, expecting $newval as defined by ArrayObject::offsetSet (see https://psalm.dev/230)

Error 1 and 2 contradict each other. And error 3 makes no sense (imho) because the argument is called $value in both ArrayObject and ArrayAccess.

The errors exist since version 5.16.0. Downgrading to 5.15.0 "solves" the problem.

[psalm-github-bot]

Hey @marcreichel, can you reproduce the issue on https://psalm.dev ?

[marcreichel]

https://psalm.dev/r/b6bf67060d

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/b6bf67060d

<?php

/**
 * @template array-key
 * @template TValue
 * @template-extends ArrayObject<array-key, TValue>
 */
class OurClass extends \ArrayObject
{
    public function offsetSet($key, $value): void
    {
        parent::offsetSet($key, $value);
    }
}

Psalm output (using commit a75d26a):

ERROR: ParamNameMismatch - 10:31 - Argument 1 of OurClass::offsetSet has wrong name $key, expecting $offset as defined by ArrayAccess::offsetSet

ERROR: ParamNameMismatch - 10:31 - Argument 1 of OurClass::offsetSet has wrong name $key, expecting $index as defined by ArrayObject::offsetSet

ERROR: ParamNameMismatch - 10:37 - Argument 2 of OurClass::offsetSet has wrong name $value, expecting $newval as defined by ArrayObject::offsetSet