We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Union "equals" has 4 params:
psalm/src/Psalm/Type/UnionTrait.php
Line 1381 in f268dfa
and e.g. https://github.com/vimeo/psalm/blob/5.x/src/Psalm/Type/Atomic/TArray.php#L87 uses the Union equals, which then causes the "equals" to return different results.
This is extremely unintuitive and causes errors to be reported/missing that are unrelated to either setting.
The text was updated successfully, but these errors were encountered:
Hey @kkmuffme, can you reproduce the issue on https://psalm.dev ?
Sorry, something went wrong.
No branches or pull requests
Union "equals" has 4 params:
psalm/src/Psalm/Type/UnionTrait.php
Line 1381 in f268dfa
The "parent node" is generally only set when taint/unused is enabled, which means that e.g. comparing arrays will return different results when taint/unused is on vs when it's not, bc the Atomic type only has 2 params:
https://github.com/vimeo/psalm/blob/5.x/src/Psalm/Type/Atomic.php#L776
and e.g. https://github.com/vimeo/psalm/blob/5.x/src/Psalm/Type/Atomic/TArray.php#L87 uses the Union equals, which then causes the "equals" to return different results.
This is extremely unintuitive and causes errors to be reported/missing that are unrelated to either setting.
The text was updated successfully, but these errors were encountered: