Don’t suggest a potential value that’s undefined

Fixes #4754
vimeo · Dec 2, 2020 · e2bb02e · e2bb02e
1 parent b64eb6d
commit e2bb02e
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/AssertionFinder.php b/src/Psalm/Internal/Analyzer/Statements/Expression/AssertionFinder.php
@@ -3733,12 +3733,25 @@ private static function getArrayKeyExistsAssertions(
                     || $atomic_type instanceof Type\Atomic\TKeyedArray
                 ) {
                     if ($atomic_type instanceof Type\Atomic\TKeyedArray) {
+                        $key_possibly_undefined = false;
+
+                        foreach ($atomic_type->properties as $property_type) {
+                            if ($property_type->possibly_undefined) {
+                                $key_possibly_undefined = true;
+                                break;
+                            }
+                        }
+
                         $key_type = $atomic_type->getGenericKeyType();
+
+                        if ($key_possibly_undefined) {
+                            $key_type->possibly_undefined = true;
+                        }
                     } else {
                         $key_type = $atomic_type->type_params[0];
                     }
 
-                    if ($key_type->allStringLiterals()) {
+                    if ($key_type->allStringLiterals() && !$key_type->possibly_undefined) {
                         foreach ($key_type->getLiteralStrings() as $array_literal_type) {
                             $literal_assertions[] = '=' . $array_literal_type->getId();
                         }

diff --git a/tests/TypeReconciliation/ArrayKeyExistsTest.php b/tests/TypeReconciliation/ArrayKeyExistsTest.php
@@ -299,6 +299,19 @@ public function getPosters($commenter, $numToGet=10) {
                     'MixedArgument',
                 ],
             ],
+            'arrayKeyExistsTwoVars' => [
+                '<?php
+                    /**
+                     * @param array{a: string, b: string, c?: string} $info
+                     */
+                    function getReason(array $info, string $key, string $value): bool {
+                        if (array_key_exists($key, $info) && $info[$key] === $value) {
+                            return true;
+                        }
+
+                        return false;
+                    }'
+            ],
         ];
     }