comments

Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>

api/Models/CommitInfo.md

@@ -8,7 +8,7 @@
 | **file\_name** | **String** | The filename of the UUID-based commit file. | [optional] [default to null] |
 | **file\_size** | **Long** | The size of the commit file in bytes. | [optional] [default to null] |
 | **file\_modification\_timestamp** | **Long** | The modification time of the commit file. | [optional] [default to null] |
-| **is\_disown\_commit** | **Boolean** | Indicates if this commit is a disown commit that removes UC as the commit coordinator from the table. | [optional] [default to null] |
+| **is\_disown\_commit** | **Boolean** | Indicates if this commit is to remove UC as the commit coordinator from the table. | [optional] [default to null] |
 
 [[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)
 

api/Models/GetCommits.md

@@ -3,7 +3,7 @@
 
 | Name | Type | Description | Notes |
 |------------ | ------------- | ------------- | -------------|
-| **table\_id** | **String** | The ID of the table to get commits for. In the context of UC, this is the UUID that uniquely identifies a table. | [default to null] |
+| **table\_id** | **String** | The table ID provided by UC on table creation that we want to get the commits for. In the context of UC, this is the UUID that uniquely identifies a table. | [default to null] |
 | **table\_uri** | **String** | The URI of the storage location of the table. If the table_id exists but the table_uri is  different from the one previously registered (e.g., if the client moved the table), the request will fail.  | [default to null] |
 | **start\_version** | **Long** | The start version from which to retrieve commits (inclusive). | [default to null] |
 | **end\_version** | **Long** | The end version upto which to retrieve commits (inclusive). | [optional] [default to null] |

api/all.yaml

@@ -40,7 +40,7 @@ tags:
       A metastore is the top-level container of objects in Unity Catalog that stores all UC assets.
   - name: CoordinatedCommits
     description: |
-      "Coordinated commits" is a Delta tables feature that allows Delta tables to designate a coordinator to coordinate commits. This is Unity Catalog's API to allow Unity Catalog be the commit coordinator for managed tables.
+      "Coordinated commits" is a Delta tables feature that allows Delta tables to designate a coordinator to coordinate commits. This is Unity Catalog's API to allow Unity Catalog be the commit coordinator for managed tables. (See https://github.com/delta-io/delta/blob/master/PROTOCOL.md for more details)
 paths:
   /catalogs:
     post:
@@ -2514,7 +2514,7 @@ components:
           description: The modification time of the commit file.
         is_disown_commit:
           type: boolean
-          description: Indicates if this commit is a disown commit that removes UC as the commit coordinator from the table.
+          description: Indicates if this commit is to remove UC as the commit coordinator from the table.
     CommitResponse:
       type: object
       description: The response for the commit action
@@ -2523,7 +2523,7 @@ components:
       properties:
         table_id:
           type: string
-          description: The ID of the table to get commits for. In the context of UC, this is the UUID that uniquely identifies a table.
+          description: The table ID provided by UC on table creation that we want to get the commits for. In the context of UC, this is the UUID that uniquely identifies a table.
         table_uri:
           type: string
           description: |

server/src/main/java/io/unitycatalog/server/persist/dao/CommitDAO.java

@@ -61,7 +61,6 @@ public CommitInfo toCommitInfo() {
   }
 
   public static CommitDAO from(Commit commit) {
-    // TODO: how to set ID and metastore ID?
     return CommitDAO.builder()
         .tableId(UUID.fromString(commit.getTableId()))
         .commitVersion(commit.getCommitInfo().getVersion())