fix(dash-playlist-loader): clear out timers on dispose #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldayananda
reviewed
Apr 16, 2019
src/dash-playlist-loader.js
Outdated
| @@ -332,6 +334,7 @@ export default class DashPlaylistLoader extends EventTarget { | |||
| if (!playlist.sidx) { | |||
| // Continue asynchronously if there is no sidx | |||
| // wait one tick to allow haveMaster to run first on a child loader | |||
| window.clearTimeout(this.mediaRequest_); | |||
There was a problem hiding this comment.
why are we clearing here? seems like this should happen in haveMaster and haveMetadata where mediaRequest is set to null currently
src/dash-playlist-loader.js
Outdated
| @@ -626,7 +630,8 @@ export default class DashPlaylistLoader extends EventTarget { | |||
| // would be to update the manifest at the same rate that the media playlists | |||
| // are "refreshed", i.e. every targetDuration. | |||
| if (this.master && this.master.minimumUpdatePeriod) { | |||
| window.setTimeout(() => { | |||
| window.clearTimeout(this.minimumUpdatePeriodTimeout_); | |||
There was a problem hiding this comment.
I think we don't intend for this to happen. If you had a timeout set to go off at 3000ms and are now(at 2500ms) trying to set one to go off at 6000ms, you should be able to. Following what mediaUpdateTimeout does may be what we want, where the timeout is cleared if we reload the loader or pause it
ldayananda
reviewed
Apr 16, 2019
src/dash-playlist-loader.js
Outdated
| @@ -483,6 +487,7 @@ export default class DashPlaylistLoader extends EventTarget { | |||
| // We don't need to request the master manifest again | |||
| // Call this asynchronously to match the xhr request behavior below | |||
| if (this.masterPlaylistLoader_) { | |||
| window.clearTimeout(this.mediaRequest_); | |||
There was a problem hiding this comment.
probably should remove this too
src/dash-playlist-loader.js
Outdated
| @@ -698,7 +703,8 @@ export default class DashPlaylistLoader extends EventTarget { | |||
| // update loader's sidxMapping with parsed sidx box | |||
| this.sidxMapping_[sidxKey].sidx = sidx; | |||
|
|
|||
| window.setTimeout(() => { | |||
| window.clearTimeout(this.minimumUpdatePeriodTimeout_); | |||
src/dash-playlist-loader.js
Outdated
| @@ -714,7 +720,8 @@ export default class DashPlaylistLoader extends EventTarget { | |||
| } | |||
| } | |||
|
|
|||
| window.setTimeout(() => { | |||
| window.clearTimeout(this.minimumUpdatePeriodTimeout_); | |||
ldayananda
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.