Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(demo): Remove error on iOS on demo page #1493

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

mister-ben
Copy link
Contributor

Description

Removes an error on the demo page with native playback from an unguarded call to property on player.tech_.vhs

Specific Changes proposed

Using && since this page should be usable on old Chrome.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.26%. Comparing base (e46247f) to head (3f3ba51).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1493   +/-   ##
=======================================
  Coverage   86.26%   86.26%           
=======================================
  Files          43       43           
  Lines       10877    10877           
  Branches     2501     2501           
=======================================
  Hits         9383     9383           
  Misses       1494     1494           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben merged commit c50ba7e into videojs:main Feb 28, 2024
7 checks passed
@mister-ben mister-ben deleted the fix-demo branch February 28, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants