Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update CI and release workflows #1397

Merged
merged 2 commits into from
May 15, 2023

Conversation

philjhale
Copy link
Contributor

Description

  • Update deprecated set-output command. This will stop working in June 2023. See this post.
  • Update actions to use Node 16 rather than Node 12. Github are currently migrating away from Node 12. See this post.
    GabrielBB/xvfb-action is no longer maintained and there is no Node 16 version. Therefore it was replaced with coactions/setup-xvfb.

* Update deprecated set-output command.
* Update actions to use Node 16 rather than Node 12.
@welcome
Copy link

welcome bot commented May 11, 2023

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #1397 (6a40c6a) into main (d28a33b) will not change coverage.
The diff coverage is n/a.

❗ Current head 6a40c6a differs from pull request most recent head cfec94e. Consider uploading reports for the commit cfec94e to get more accurate results

@@           Coverage Diff           @@
##             main    #1397   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files          40       40           
  Lines       10017    10017           
  Branches     2319     2319           
=======================================
  Hits         8561     8561           
  Misses       1456     1456           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adrums86 adrums86 merged commit 12b378a into videojs:main May 15, 2023
@welcome
Copy link

welcome bot commented May 15, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@philjhale philjhale deleted the update-workflows branch May 16, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants